Skip to content

fix: fix multiple bugs in web search, prompts, and tool definitions#1344

Open
Ricardo-M-L wants to merge 1 commit intoFoundationAgents:mainfrom
Ricardo-M-L:fix/multiple-bug-fixes
Open

fix: fix multiple bugs in web search, prompts, and tool definitions#1344
Ricardo-M-L wants to merge 1 commit intoFoundationAgents:mainfrom
Ricardo-M-L:fix/multiple-bug-fixes

Conversation

@Ricardo-M-L
Copy link
Copy Markdown

@Ricardo-M-L Ricardo-M-L commented Apr 3, 2026

Summary

  • Fix failed_engines list never being populated in web_search.py — logging about failed/retried engines was dead code
  • Fix missing space in SYSTEM_PROMPT string concatenation in manus.py
  • Fix print with %s format string in agent_executor.py (should use f-string)
  • Fix GoogleSearchEngine returning raw dict instead of SearchItem object
  • Fix wrong type annotation str → dict in ask_human.py parameters

Test plan

  • Verify web search correctly logs failed engines
  • Verify SYSTEM_PROMPT renders with proper spacing
  • Verify Google search returns proper SearchItem objects

🤖 Generated with Claude Code

@claude
fix: fix multiple bugs in web search, prompts, and tool definitions
bdc736d 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Ricardo-M-L
Copy link
Copy Markdown
Author

Ricardo-M-L commented Apr 17, 2026

Friendly bump — this fork PR's workflow run is stuck on action_required (GitHub's default for first-time contributors). Could a maintainer approve the workflow so CI can report a verdict? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Ricardo-M-L